Follow-up with the review request

This assume that you have raise a request for review and want to check the status of the review

Find your request for review#

On the left menu of https://git.tsp.dev/tsp/wiki/, select Code > Merge Requests

You should see the following page. There are 4 tabs in the page:

• Open: review requests that has not been accepted yet.
• Merged: review requests that has been accepted.
• Closed: review requests that has been abandoned and no longer in used.
• All: all review requests so far.

Click on a review request name. It should show you information of the review process, including:

• The title, description and changes of the review request
• Status of the review.
• Activities of people involved in the review
• A chat thread at the bottom for discussion between people involved in the review.

Follow up on Merged Requests#

You should always check if your merge request has been successfully deployed. After finding youe merge request from the previous step, you will be able to see if the merge request is successful or it has failed.

If the MR is successful, you will see 3 green ticks in the pipeline like the image below

If the MR is unsuccessful, you will be able to see at which point in the pipeline that the MR failed. At which point, you should reach out to the reviewer or maintainer to check the error (see below).

Continue to edit#

You can continue to edit content of a review request, as long as it is not yet accepted or rejected.

On the top right corner, click on the button “Code” and select “Open in Web IDE”.

This should open a new web IDE for you to continue on the update.

Reject the review request#

While content editors cannot approve a review request, they can close an opened request.

On the top right corner, click on the menu icon and select “Close merge request”

The status of the request should be changed to “Closed” after the action is taken

Reopen a closed request#

‘Reopen’ means that you want to resume the review progress again on a previously closed request.

On the top right corner, click on the menu icon and select “Reopen merge request”

The status of the request should be changed to “Opened” after the action is taken.

Suggested flow#

Use merge request’s comment section to document reviews and changelogs#

If a merge request contains unwanted changes or needs further modification, reviewer should comment into the mrege request and inform the editor to update the content .

Avoid closing a merge request unless it is not usable or editor prefers to start again from scratch.